Feature/leeds crc new #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollietulloch
reviewed
Dec 5, 2025
Contributor
ollietulloch
left a comment
ollietulloch
left a comment
There was a problem hiding this comment.
Thanks @shilpigoeldev, a few initial comments added
| def populate_raw_field_variables(record) | ||
| @report = record.raw_fields['report'] | ||
| @moltestingtype = record.raw_fields['moleculartestingtype'] | ||
| @value1 = record.raw_fields['proteinimpact'] |
Contributor
There was a problem hiding this comment.
Could these @value.. instance variables be given more meaningful names please?
Contributor
Author
There was a problem hiding this comment.
Hi @ollietulloch ,These variable names are what we are receiving in the file , so are aligned with the rules designed by Fiona and hence I used same names.
Contributor
There was a problem hiding this comment.
Thanks @shilpigoeldev, I can see why you stuck with those names, they just seem a little meaningless wen review code without that context
NImeson
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I have added a new importer for Leeds colorectal new version of files.
How?
By updating importer script and adding new handler.
Testing?
QA counts have been signed off and test added.
Anything Else?
N/A